Refactor CSS to support review drafts #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that almost everything is on Bikeshed, this distinction doesn't save anything.
It is no longer used; we instead use either Bikeshed's built-in definition feature, or a specific one for HTML found in https://github.com/whatwg/html/blob/master/html-dfn.js.
domenic
added a commit
to domenic/bikeshed
that referenced
this pull request
May 9, 2018
Assumes the filenames in whatwg/whatwg.org#200
domenic
added a commit
to domenic/bikeshed
that referenced
this pull request
May 9, 2018
Assumes the filenames in whatwg/whatwg.org#200
This was referenced May 9, 2018
annevk
reviewed
May 11, 2018
|
Oops, good catch, will fix and force push. And yeah, that's the idea. Any thoughts on a better name? Maybe "standard-or-review-draft.css"? :-/ |
|
Perhaps |
This will require corresponding changes to the WHATWG boilerplate used in Bikeshed.
|
Fixed |
annevk
approved these changes
May 12, 2018
16 tasks
tabatkins
pushed a commit
to speced/bikeshed
that referenced
this pull request
May 29, 2018
Assumes the filenames in whatwg/whatwg.org#200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of whatwg/sg#70.
The dfn.js change is a tagalong; I could split that out if people want.
To deploy this, we'd need to land this and speced/bikeshed#1239 at around the same time, then trigger Travis rebuilds of every spec.